1.0 alpha 8 (Sourcery refactored) #282
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if isinstance(self._style_url, StyleUrl): | ||
| return self._style_url.url | ||
| return None | ||
| return self._style_url.url if isinstance(self._style_url, StyleUrl) else None |
There was a problem hiding this comment.
Function _Feature.style_url refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if self._geometry is not None: | ||
| return self._geometry.geometry | ||
| return None | ||
| return self._geometry.geometry if self._geometry is not None else None |
There was a problem hiding this comment.
Function Placemark.geometry refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| doc = """<kml xmlns="http://www.opengis.net/kml/2.2"> | ||
| if LXML: | ||
| config.set_etree_implementation(lxml.etree) | ||
| doc = """<kml xmlns="http://www.opengis.net/kml/2.2"> | ||
| <Placemark> | ||
| <ExtendedData> | ||
| <lc:attachment>image.png</lc:attachment> | ||
| </ExtendedData> | ||
| </Placemark> </kml>""" | ||
| if LXML: | ||
| config.set_etree_implementation(lxml.etree) |
There was a problem hiding this comment.
Function TestKmlFromString.test_from_string_with_unbound_prefix refactored with the following changes:
- Move assignments closer to their usage (
move-assign)
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #282 +/- ##
===========================================
+ Coverage 91.74% 91.78% +0.03%
===========================================
Files 40 40
Lines 4533 4529 -4
===========================================
- Hits 4159 4157 -2
+ Misses 374 372 -2 ☔ View full report in Codecov by Sentry. |
Pull Request #281 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
developbranch, then run:Help us improve this pull request!